Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome optional permissions update #22034

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Jan 26, 2024

Summary

This change aligns the compatibility information with the optional permission details provided by Chrome.

It only covers common permissions e.g., those shared between Firefox, Chrome, and Safari.

Related issues

Fixes #20858

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jan 26, 2024
@rebloor rebloor self-assigned this Jan 26, 2024
@queengooborg queengooborg merged commit 22b3ea5 into mdn:main Jan 28, 2024
5 checks passed
@rebloor rebloor deleted the chrome-optional_permissions-update branch January 29, 2024 01:53
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately already merged, so please submit a PR with the requested fixups.

@@ -46,6 +46,26 @@
}
}
},
"alarm": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no alarm permission, it should be "alarms".

@@ -255,7 +275,7 @@
"description": "<code>debugger</code>",
"support": {
"chrome": {
"version_added": true
"version_added": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome does support the debugger permission. Set this back to true.

Alternatively, if the objective is to drop permissions that are not on MDN from BCD, drop the debugger key.

@@ -355,12 +375,32 @@
}
}
},
"dns": {
"__compat": {
"description": "<code>dms</code>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "<code>dms</code>",
"description": "<code>dns</code>",

"description": "<code>dms</code>",
"support": {
"chrome": {
"version_added": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome does not support the dns API on release:

Note: This API is only available in Chrome Dev. There are no foreseeable plans to move this API from the dev channel into Chrome stable.

https://developer.chrome.com/docs/extensions/reference/api/dns

Comment on lines +737 to +740
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"firefox": {
"version_added": true
},
"firefox_android": {
"version_added": false
},

search is supported as an optional permission: https://searchfox.org/mozilla-central/rev/3c72de9280ec57dc55c24886c6334d9e340500e8/browser/components/extensions/schemas/search.json#10,14

rebloor added a commit to rebloor/browser-compat-data that referenced this pull request Jan 29, 2024
rebloor added a commit that referenced this pull request Jan 30, 2024
* Updating optional_permissions based on feedback to #22034

* Apply suggestions from review

Co-authored-by: Rob Wu <rob@robwu.nl>

---------

Co-authored-by: Rob Wu <rob@robwu.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional_permissions: browsingData - Chrome BCD
3 participants