-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Chrome 123 beta #22280
Updates for Chrome 123 beta #22280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api.CSSKeyframesRule.length is in 124 https://chromestatus.com/feature/6289894144212992 otherwise all LGTM.
https://chromiumdash.appspot.com/commit/a22c1207bb2c8ba2e6f88bb00c09062f980dd04f says it is shipping in Chrome 123. Is Chromestatus wrong? |
ChromeStatus was updated on the 20th to 124 by the engineer owning this.
…On Mon, Feb 26, 2024 at 9:29 AM Florian Scholz ***@***.***> wrote:
api.CSSKeyframesRule.length is in 124
https://chromestatus.com/feature/6289894144212992 otherwise all LGTM.
https://chromiumdash.appspot.com/commit/a22c1207bb2c8ba2e6f88bb00c09062f980dd04f
says it is shipping in Chrome 123. Is Chromestatus wrong?
—
Reply to this email directly, view it on GitHub
<#22280 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVDAYX6BUX4PQKQSFDEWGTYVRIXHAVCNFSM6AAAAABDUTYNU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGY3TANRUGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
[image: Google Logo]
Rachel Andrew
Staff Technical Writer
Content lead for web.dev and developer.chrome.com
***@***.*** | @rachelandrew <https://twitter.com/rachelandrew>
See go/web-devrel-content to learn how to publish content with Chrome Web
Developer Relations.
|
Thanks Rachel! Reverted the change to CSSKeyframesRule.length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged!
The chromestatus entry is wrong, I'll update it and send a PR. |
In general I would assume chromestatus is wrong if it disagrees with collector results, but it's best to investigate a bit for the few cases where it's the other way around. |
Thanks @foolip! I'm usually skeptical with the data on chromestatus but in this case the data was freshly updated by the engineer working on the feature, so that seemed like a strong hint to me that chromestatus would be correct this time. |
@Elchi3 Sometimes it is right, yeah, the collector isn't perfect. Feel free to ping me to dig through source if you're not sure about a case, as long as I see the notification I can do it pretty quickly. |
The Open Web Docs BCD collector v10.8.0 found new features shipping in Chrome 123 beta which was released yesterday. Currently, the collector covers about 88% of BCD, so the following list might not be exhaustive. Also, if a feature is in Chrome Canary/behind origin trials/enrollment, it is not considered here.
With this PR, BCD considers the following features as shipping in Chrome 123:
api.CSSKeyframesRule.lengthI think all of this is in line with what https://chromestatus.com says currently.
Again, I hope this auto-generated PR is useful to update BCD for the new Chrome 123 more easily and faster. If you have feedback, let me know! /cc @chrisdavidmills