Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pretty to text-wrap-style #22645

Closed
wants to merge 8 commits into from
Closed

added pretty to text-wrap-style #22645

wants to merge 8 commits into from

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Mar 18, 2024 •
edited
Loading

Summary

Added pretty value to the text-wrap-style property

Test results and supporting details

The property is not supported in Chromium browsers or safari and the value is not supported in FF 124

Related issues

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Mar 18, 2024
@dletorey dletorey mentioned this pull request Mar 18, 2024
Merged
dletorey and others added 2 commits March 19, 2024 09:57
@dletorey @queengooborg
Update css/properties/text-wrap-style.json
b70fbb5 
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
@dletorey
Merge branch 'main' into 32341-text-wrap
77e753b
pepelsbey
pepelsbey approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

queengooborg
queengooborg requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just noticed that this value is unsupported in all browsers. We currently aren't enforcing this specific linting rule for the CSS category, but this would fail the lint if it was.

Is this feature supported behind a flag or in any beta/nightly releases? If so, let's add that data so this would pass the linter when it's enabled. If not, let's wait to add this until a browser has support.

@dletorey
Copy link
Contributor Author

Ah, I just noticed that this value is unsupported in all browsers. We currently aren't enforcing this specific linting rule for the CSS category, but this would fail the lint if it was.

Is this feature supported behind a flag or in any beta/nightly releases? If so, let's add that data so this would pass the linter when it's enabled. If not, let's wait to add this until a browser has support.

Currently text-wrap-style: pretty has zero browser support

@queengooborg
Copy link
Collaborator

Well, now this PR is empty. 😆 I'm going to go ahead and close this since no browsers support the value, but thank you anyways!

@dletorey dletorey deleted the 32341-text-wrap branch March 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

@queengooborg queengooborg Awaiting requested review from queengooborg

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dletorey @queengooborg @pepelsbey