Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete anchor HTML attribute #22910

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Delete anchor HTML attribute #22910

merged 1 commit into from
Apr 22, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 22, 2024

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Apr 22, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit d41db04 into main Apr 22, 2024
8 checks passed
@Elchi3 Elchi3 deleted the anchor-attribute branch April 22, 2024 12:59
@chrisdavidmills
Copy link
Collaborator

It works in Canary already, so I would've preferred to keep it in but marked as preview support, as we did with the anchorElement. Would that be OK? Either way, we should probably be consistent across the two of them.

@foolip
Copy link
Collaborator Author

foolip commented Apr 22, 2024

Oh, sorry, since I didn't see anchorElement in #22903 I assumed that wasn't in BCD, but it was included in #22813. These two go together, so I'll restore this with "preview".

foolip added a commit to foolip/browser-compat-data that referenced this pull request Apr 22, 2024
This reverts mdn#22910
but uses version "preview" instead of "125".
@mfreed7
Copy link
Contributor

mfreed7 commented Apr 22, 2024

So neither anchor nor anchorElement should be working in 125 (Beta) or 126 (Canary). Make sure to turn off Experimental Web Platform Features. If you still see either of those functioning, please file a bug, but I just checked and don't see support.

@foolip
Copy link
Collaborator Author

foolip commented Apr 22, 2024

The guidelines for the use of "preview" are here:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#choosing-preview-values

It's used relatively little in BCD and experimental flags are used a lot more, but an upside of using "preview" is that you don't have to pick a version number, so there's no risk of the flags being removed and the originally guessed version number turning into the official version number.

@chrisdavidmills
Copy link
Collaborator

So neither anchor nor anchorElement should be working in 125 (Beta) or 126 (Canary). Make sure to turn off Experimental Web Platform Features. If you still see either of those functioning, please file a bug, but I just checked and don't see support.

My bad — I did have this flag active. Sorry for the confusion.

@chrisdavidmills
Copy link
Collaborator

The guidelines for the use of "preview" are here: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#choosing-preview-values

It's used relatively little in BCD and experimental flags are used a lot more, but an upside of using "preview" is that you don't have to pick a version number, so there's no risk of the flags being removed and the originally guessed version number turning into the official version number.

Now that I realize these features are behind a flag, I think it would good to report the flag data in their BCD. Is it appropriate to report the flag data and use the "preview" value at the same time?

@foolip
Copy link
Collaborator Author

foolip commented Apr 23, 2024

@chrisdavidmills I've never seen that done, but if no lint complains about the combination or flags and "preview", that seems fine.

Elchi3 pushed a commit that referenced this pull request Apr 24, 2024
* Add back the anchor HTML attribute

This reverts #22910
but uses version "preview" instead of "125".

* Use experimental flag for anchor/anchorElement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants