Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark PressureObserver as not supported on Chrome Android #23123

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented May 17, 2024

The API was exposed on Android but didn't actually work:
https://groups.google.com/a/chromium.org/g/blink-dev/c/7leKysvPZWk/m/-0fKweJ5AQAJ

TODO: figure out if it's exposed but just doesn't do anything:
https://groups.google.com/a/chromium.org/g/blink-dev/c/7leKysvPZWk/m/-0fKweJ5AQAJ

This now matches the other features tagged with web-features:compute-pressure.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 17, 2024
@Elchi3
Copy link
Member

Elchi3 commented May 27, 2024

Looks like this is indeed exposed but doesn't do anything. See https://issues.chromium.org/issues/341537009. Do you want to undraft this PR?

@foolip
Copy link
Collaborator Author

foolip commented May 27, 2024

Cool, so https://chromiumdash.appspot.com/commit/19e7787191b2c63223077e0812a9ddbbaeced6d9 should be in 127. That means we should have a partial implementation with notes for 125-126 that says the API is exposed but doesn't work. It'll require a lot of the same note, but I don't know what else we could do.

@Elchi3
Copy link
Member

Elchi3 commented May 27, 2024

Sounds good to me.
(Alternatively, we could just mark everything as false and pretend the early exposure never happened. This might require overrides in the collector, though)

@Elchi3
Copy link
Member

Elchi3 commented Jul 4, 2024

@foolip do you want to follow up on this one?

@foolip
Copy link
Collaborator Author

foolip commented Jul 4, 2024

Alternatively, we could just mark everything as false and pretend the early exposure never happened.

I like the simplicity of this, it means just landing this PR. I've checked that with this applied, npm run traverse -- -b chrome_android -f mirror | grep -i pressure doesn't list anything related to this feature.

@foolip foolip marked this pull request as ready for review July 4, 2024 11:40
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, let's land this then! 👍

@Elchi3 Elchi3 merged commit 7123fcd into mdn:main Jul 4, 2024
5 checks passed
@foolip foolip deleted the compute-pressure-android branch July 4, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants