Clean up data for Permissions Policy header #23470
Conversation
github-actions
bot
added
the
data:http 🚠
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
http/headers/Permissions-Policy.json
Outdated
| } | ||
| } | ||
| }, | ||
| "battery": { |
There was a problem hiding this comment.
Mind adding battery in a separate PR?
There was a problem hiding this comment.
To avoid merge conflicts, I feel it is best to keep it all in the same PR -- but if still desired, I can split it out!
There was a problem hiding this comment.
I have removed it in 521b2de and we can simply revert that in a separate PR after merging this, which shouldn't cause a merge conflict.
This comment has been minimized.
This comment has been minimized.
http/headers/Permissions-Policy.json
Outdated
| } | ||
| } | ||
| }, | ||
| "battery": { |
There was a problem hiding this comment.
I have removed it in 521b2de and we can simply revert that in a separate PR after merging this, which shouldn't cause a merge conflict.
There was a problem hiding this comment.
Originally I approved this PR, but it looks like this PR does more than what's described in the PR description.
In particular, this PR seems to remove the "Feature-Policy", and therefore changes the support data for the gamepad and speaker-selection permissions, causing the lint issues.
|
The changes regarding the removal of "Feature-Policy" were stated in the description, in that the alternative name was removed from all subfeatures. The failing lint is actually not because of that change, though, but rather because |
This PR cleans up a lot of data for the Permissions Policy HTTP header. The alternative name was copied down to all subfeatures, which is improper.
Additionally, this marks the header as unsupported in Firefox and Safari, as the header is not supported, and support was only indicated because the values are supported as values to
<iframe allow="">. The features were copied to #23487 to untangle this data.This fixes #15987.