Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDN URLs for chapterInfo features #23512

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

chrisdavidmills
Copy link
Collaborator

Summary

In mdn/content#34400, I add documentation for the Media Session API MediaMetadata chapterInfo functionality.

I saw that the BCD for these features was already added, but there were no MDN URLs. This PR adds the missing MDN URLs.

One small point — the spec URLs look correct, but in the local page previews, the "No specification found" box pops up. I'm not sure what the problem is.

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 25, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that the BCD for these features was already added, but there were no MDN URLs. This PR adds the missing MDN URLs.

Thanks Chris, this work will soon be automated away for you by yours truly: #23431 Less things to worry about :)

One small point — the spec URLs look correct, but in the local page previews, the "No specification found" box pops up. I'm not sure what the problem is.

Looks good here https://pr34400.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/ChapterInformation/artwork, so maybe you need to update your local packages as the data comes from the web-specs package.

@Elchi3 Elchi3 merged commit 32e9c61 into mdn:main Jun 25, 2024
5 checks passed
@chrisdavidmills
Copy link
Collaborator Author

I saw that the BCD for these features was already added, but there were no MDN URLs. This PR adds the missing MDN URLs.

Thanks Chris, this work will soon be automated away for you by yours truly: #23431 Less things to worry about :)

You bloody superhero ;-) 🦸‍♂️

One small point — the spec URLs look correct, but in the local page previews, the "No specification found" box pops up. I'm not sure what the problem is.

Looks good here https://pr34400.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/ChapterInformation/artwork, so maybe you need to update your local packages as the data comes from the web-specs package.

Cool, I'll have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants