Update Chrome/Safari versions for sandbox="allow-top-navigation" #23862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was implemented in WebKit 533.3: WebKit/WebKit@f4228dc https://github.com/WebKit/WebKit/blob/f4228dc0076684651c8b54680db4d1d7b964a321/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 or 6, Safari 5, and iOS 4.2. Chrome 5 or 6 is ambiguous because the engine version is 533 with no minor version. Chrome 6 is 534.3, so it was definitely in Chrome 6. Unlike other sandbox data, mirroring can be used for iOS, as Safari 5 does map to iOS 4.2.
github-actions
bot
added
the
data:html 📄
ddbeck
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was implemented in WebKit 533.3:
WebKit/WebKit@f4228dc
https://github.com/WebKit/WebKit/blob/f4228dc0076684651c8b54680db4d1d7b964a321/WebCore/Configurations/Version.xcconfig
That maps to Chrome 5 or 6, Safari 5, and iOS 4.2.
Chrome 5 or 6 is ambiguous because the engine version is 533 with no
minor version. Chrome 6 is 534.3, so it was definitely in Chrome 6.
Unlike other sandbox data, mirroring can be used for iOS, as Safari 5
does map to iOS 4.2.