Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 8 added webextensions.api.management support #24278

Merged

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the management Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://source.chromium.org/chromium/chromium/src/+/eb25577b3822e6bd44f3c42ff5a1ef28ada1e6dd

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `management` Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://source.chromium.org/chromium/chromium/src/+/eb25577b3822e6bd44f3c42ff5a1ef28ada1e6dd
@queengooborg queengooborg added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 3, 2024
@queengooborg queengooborg added the KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. label Sep 3, 2024
@rebloor
Copy link
Contributor

rebloor commented Sep 5, 2024

@queengooborg how did you get version 24? The only relevant info I can see is the commit date of October 2010, which would suggest an earlier release (6).

@queengooborg
Copy link
Contributor Author

Good catch, thanks!

It looks like these features actually landed in Chrome 9, based upon an internal document that lists the feature freeze dates of Chrome (typically two months prior to the release of that version). Chrome 9's feature freeze was November 5, 2010 (8's was September 24, 2010)!

@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Nov 20, 2024
@caugner

This comment was marked as duplicate.

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these features actually landed in Chrome 9, based upon an internal document that lists the feature freeze dates of Chrome (typically two months prior to the release of that version). Chrome 9's feature freeze was November 5, 2010 (8's was September 24, 2010)!

Based on chromium/chromium@eb25577, this commit landed in 7.0.547.0, but since Chrome 7 was based on 7.0.517 (BEFORE that), it makes sense that this landed in Chrome 8 (based on 8.0.552), not Chrome 9.

@caugner caugner changed the title Update Chromium data for management Web Extensions interface Chromium 8 added webextensions.api.management support Nov 22, 2024
@caugner caugner changed the title Chromium 8 added webextensions.api.management support Chrome 8 added webextensions.api.management support Nov 22, 2024
@caugner caugner merged commit 4f6c7a5 into mdn:main Nov 22, 2024
7 checks passed
@queengooborg queengooborg deleted the webextensions/api/management/chrome-corrections branch November 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants