Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium data for commands Web Extensions manifest property #24293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

queengooborg
Copy link
Collaborator

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the commands Web Extensions manifest property. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://chromiumdash.appspot.com/commit/8e1b9cf4b212c6596d979b333c1627d6acb714e2

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `commands` Web Extensions manifest property. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://chromiumdash.appspot.com/commit/8e1b9cf4b212c6596d979b333c1627d6acb714e2
@queengooborg queengooborg added data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values. labels Sep 3, 2024
Copy link
Collaborator

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg _execute_action should remain at 88 - the MV3 features landed sooner but the release was 88. Also, _execute_browser_action and _execute_page_action will have been earlier - most likely with the action and page action APIs (but I have no more information).

@queengooborg
Copy link
Collaborator Author

What should we do for _execute_browser_action and _execute_page_action then? We could set them as ranges, though I'm working to eliminate to ranges (and focusing on webextensions to start)!

@rebloor
Copy link
Collaborator

rebloor commented Sep 5, 2024

@dotproto Any thoughts on how we find when _execute_browser_action and _execute_page_action were implemented in Chrome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD 🔑 Key Result: Eliminate true/null values and replace them with "real" values.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants