Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-features): sync names with v2 #24687

Merged
merged 2 commits into from
Oct 11, 2024
Merged

chore(web-features): sync names with v2 #24687

merged 2 commits into from
Oct 11, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 10, 2024

Summary

Sync web-feature names that changes in web-features v2.0.0.

Test results and supporting details

Related issues

@caugner caugner requested a review from ddbeck October 10, 2024 14:32
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 10, 2024
@caugner caugner requested a review from Elchi3 October 11, 2024 11:03
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg runs a script that generates PRs like #24476.

It should take care of these renames, I think. It lives in web-features and is not yet run automatically but Vinyl has a task to implement just that. https://github.com/web-platform-dx/web-features/blob/main/scripts/migrate-to-bcd.ts

What's the status of this work, Vinyl?

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, this PR LGTM.

@caugner caugner merged commit 5d14600 into main Oct 11, 2024
8 checks passed
@caugner caugner deleted the web-features-v2 branch October 11, 2024 12:23
@queengooborg
Copy link
Collaborator

Renames like this are taken care of by that script, yes! The script is all done, it just needs to be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants