Update & fix nodejs data for Crypto
#24979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
caugner
requested changes
Nov 12, 2024
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
caugner
previously requested changes
Nov 21, 2024
github-actions
bot
added
size:m
queengooborg
requested changes
Dec 1, 2024
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
queengooborg
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The support for the Web Crypto API is:
in v15.0.0, the API has been shipped, but can't access globally, access via the
cryptomodule with the alternative namewebcryptovia nodejs/node#35093in v17.6.0, v16.15.0, the API can be available to global context, but need to be enabled with
--experimental-global-webcryptoCLI flag via nodejs/node#41938in v19.0.0, the API is available to global context without flags, but can be disabled with
--no-experimental-global-webcryptoCLI flag via nodejs/node#42083in v23.0.0, the API is marked as not experimental via nodejs/node#52564
See also:
https://nodejs.org/docs/latest/api/globals.html#crypto
https://nodejs.org/docs/latest/api/webcrypto.html#class-crypto
https://nodejs.org/docs/latest/api/crypto.html#cryptorandomuuidoptions
https://nodejs.org/docs/latest/api/crypto.html#cryptogetrandomvaluestypedarray
Also fixes #23784
Also note that the fix in #21414 and the test in #20752 is not correct, as the issue and PR use the link of the
getRandomValues()method ofcryptomodule (which says v17.4.0), NOT thegetRandomValues()method of Web Crypto API (which says v15.0.0). Also notice that, thegetRandomValues()method ofcryptomodule is simply a convenient alias of thegetRandomValues()method of Web Crypto APITest results and supporting details
Related issues