-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox supports Server-Timing as HTTP trailer, but only exposes it to DevTools #25141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in Fx devtools only
github-actions
bot
added
the
data:http
Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
label
Nov 20, 2024
FWIW I only found this indirectly related WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=178069 |
caugner
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caugner
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit.
caugner
approved these changes
Nov 22, 2024
caugner
changed the title
chore(http): Clarify Trailer support, partial support for Server-Timing in Fx devtools only
Server-Timing/Trailer headers are only partially supported by Firefox
Nov 22, 2024
caugner
changed the title
Server-Timing/Trailer headers are only partially supported by Firefox
Firefox recognizes Server-Timing header, but only partially supports Trailer headers (DevTools only)
Nov 22, 2024
caugner
changed the title
Firefox recognizes Server-Timing header, but only partially supports Trailer headers (DevTools only)
Firefox recognizes Server-Timing header, but only partially supports it as Trailer (DevTools only)
Nov 22, 2024
Merged
caugner
changed the title
Firefox recognizes Server-Timing header, but only partially supports it as Trailer (DevTools only)
Firefox supports Server-Timing header, but only partially supports it as Trailer (DevTools only)
Nov 22, 2024
caugner
changed the title
Firefox supports Server-Timing header, but only partially supports it as Trailer (DevTools only)
Firefox supports Server-Timing as HTTP trailer, but only exposes it to DevTools
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The support for HTTP Trailer header is misleading, as it's removed from the Fetch spec & not accessible there anyway / XHR. As far as I can see, the only support that exists in browsers is exclusively for
Server-Timing
, and at that, it's only used for DevTools in Network -> Timing, all other headers (as trailers) are a no-op / discarded. For this reason, I've set it to partial support forTrailer
, and full support for Server-Timing header as trailer, which no other browser appears to do.Test results and supporting details
Firefox
Server-Timing
implementation bug -> https://bugzilla.mozilla.org/show_bug.cgi?id=1403051:ChrBugs -> https://issues.chromium.org/issues/40811358
Node repro:
Related issues