Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -webkit-mask-box-image aliases #25155

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Nov 20, 2024

Summary

This removes the 5 -webkit-mask-box-image aliases as standalone properties, as they already exist as alternative names in the properties they are aliases for. See #22727 and #22718 for more background.

Test results and supporting details

The support data for the alternative names in the keys they are aliases for was already more precise than in the files that are being deleted.

  • -webkit-mask-box-image-outset
    • alias for mask-border-outset
    • alternative_name set for Chrome and Safari
  • -webkit-mask-box-image-slice
    • alias for mask-border-slice
    • alternative_name set for Chrome and Safari
  • -webkit-mask-box-image-repeat
    • alias for mask-border-repeat
    • alternative_name set for Chrome and Safari
  • -webkit-mask-box-image-source
    • alias for mask-border-source
    • alternative_name set for Chrome and Safari
  • -webkit-mask-box-image-width
    • alias for mask-border-width
    • alternative_name set for Chrome and Safari

Related issues

Fixes #22727

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:l [PR only] 101-1000 LoC changed labels Nov 20, 2024
@jamesnw
Copy link
Contributor Author

jamesnw commented Nov 20, 2024

@ddbeck or @Elchi3 Can you confirm the alternative names is what was meant by folding in "files into their standard names, similar to most of these aliases"?

@caugner caugner self-requested a review November 20, 2024 16:12
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified for all five properties that the data is already contained or more specific in the unprefixed data.

@caugner caugner merged commit b35c062 into mdn:main Nov 20, 2024
6 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge -webkit-mask-box-image entries into their unprefixed property
2 participants