Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 130 supports connection events with Bluetooth RFCOMM serial ports #25234

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Nov 26, 2024

…onected events

Summary

Chrome 130 supports the SerialPort.connected attribute, a boolean that reports whether a serial port is logically connected. This property is already represented in BCD.

However, another part of this work item is that the SerialPort connect and disconnect events were previously only fired by physical/wired serial ports. With this change, wireless Bluetooth RFCOMM serial ports also fire these events when they connect and disconnect.

This PR adds a data point to cover this new wireless support for the events. Note that it looks like this change is a result of a spec change (I'm not sure which exact spec change, but WICG/serial#189 mentions adding Bluetooth support) rather than Chrome previously having partial support. As a result, I've added a sub-data point rather than another support item in the same support array.

Test results and supporting details

See https://chromestatus.com/feature/5118102654418944

Related issues

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Nov 26, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

api/SerialPort.json Outdated Show resolved Hide resolved
api/SerialPort.json Outdated Show resolved Hide resolved
@caugner caugner changed the title Chrome 130 Bluetooth RFCOMM support for SerialPort connected and disc… Chrome 130 supports (dis)connected events with Bluetooth RFCOMM serial ports Nov 26, 2024
@caugner caugner changed the title Chrome 130 supports (dis)connected events with Bluetooth RFCOMM serial ports Chrome 130 supports connection events with Bluetooth RFCOMM serial ports Nov 26, 2024
chrisdavidmills and others added 2 commits November 27, 2024 09:59
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@chrisdavidmills
Copy link
Contributor Author

WFM; thanks @caugner!

@chrisdavidmills chrisdavidmills merged commit f0ca5a2 into mdn:main Nov 27, 2024
7 checks passed
@chrisdavidmills chrisdavidmills deleted the web-serial-connected-disconnected-event-rfcomm-support branch November 27, 2024 10:06
@mdn-bot mdn-bot mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants