Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove svg.elements.feFlood.{flood-color,flood-opacity} for duplicate global attributes #25259

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 29, 2024

Summary

duplicate global attributes

see also #25240, https://drafts.fxtf.org/filter-effects/#feFloodElement, https://svgwg.org/svg2-draft/styling.html#PresentationAttributes

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG label Nov 29, 2024
@skyclouds2001 skyclouds2001 changed the title Remove svg.elements.feFlood.{flood-color,flood-opacity} for dupliute … Remove svg.elements.feFlood.{flood-color,flood-opacity} for dupliute global attributes Nov 29, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Nov 29, 2024
@skyclouds2001 skyclouds2001 changed the title Remove svg.elements.feFlood.{flood-color,flood-opacity} for dupliute global attributes Remove svg.elements.feFlood.{flood-color,flood-opacity} for duplicate global attributes Nov 29, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 29, 2024 01:15
@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Nov 29, 2024

"flood-color": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/SVG/Attribute/flood-color",
"spec_url": "https://drafts.fxtf.org/filter-effects/#FloodColorProperty",
"tags": [
"web-features:svg-filters"
],
"support": {
"chrome": {
"version_added": "5"
},
"chrome_android": "mirror",
"edge": {
"version_added": "12"
},
"firefox": {
"version_added": "3"
},
"firefox_android": "mirror",
"ie": {
"version_added": "≤11"
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "6"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"flood-opacity": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/SVG/Attribute/flood-opacity",
"spec_url": "https://drafts.fxtf.org/filter-effects/#FloodOpacityProperty",
"tags": [
"web-features:svg-filters"
],
"support": {
"chrome": {
"version_added": "5"
},
"chrome_android": "mirror",
"edge": {
"version_added": "12"
},
"firefox": {
"version_added": "3"
},
"firefox_android": "mirror",
"ie": {
"version_added": "≤11"
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "6"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

diff with global attributes is on i.e. and edge of flood-opacity attribute, check that global attribute is more correct and align with others

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, data is identical except for feFlood.flood-opacity having ie.version_added = false.

@caugner caugner merged commit 2acad1a into mdn:main Nov 29, 2024
6 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 29, 2024
@skyclouds2001 skyclouds2001 deleted the svg.elements.feFlood.{flood-color,flood-opacity} branch November 29, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants