-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Request()
constructor init.duplex
parameter
#25488
Conversation
api/Request.json
Outdated
"nodejs": [ | ||
{ | ||
"version_added": "19.3.0" | ||
}, | ||
{ | ||
"version_added": "18.13.0", | ||
"version_removed": "19.0.0" | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share links to the PRs/commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is added in nodejs/node@216b5a1#diff-1548e1d5e2941cd3f8042e4b5bf7f5f985e48bd7aee50f938739f9e067366e8cR476-R480, and nodejs/node#45236, so the version should be 19.1.0, 18.13.0, 16.19.0
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
c735b98
to
0a53248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
Summary
data taken from
Request.duplex
Test results and supporting details
Spec proposal change at whatwg/fetch#1493
Related issues
Relates to mdn/content#31735
Depends on #25486 and #25487