Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request() constructor init.duplex parameter #25488

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 22, 2024

Summary

data taken from Request.duplex

Test results and supporting details

Spec proposal change at whatwg/fetch#1493

Related issues

Relates to mdn/content#31735
Depends on #25486 and #25487

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Dec 22, 2024
@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Dec 29, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 29, 2024 14:24
api/Request.json Outdated Show resolved Hide resolved
api/Request.json Outdated
Comment on lines 245 to 265
"nodejs": [
{
"version_added": "19.3.0"
},
{
"version_added": "18.13.0",
"version_removed": "19.0.0"
}
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share links to the PRs/commits?

Copy link
Contributor Author

@skyclouds2001 skyclouds2001 Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was marked as off-topic.

api/Request.json Show resolved Hide resolved
@skyclouds2001 skyclouds2001 marked this pull request as draft January 6, 2025 15:13
api/Request.json Outdated Show resolved Hide resolved
browsers/nodejs.json Outdated Show resolved Hide resolved
api/Request.json Show resolved Hide resolved
skyclouds2001 and others added 4 commits January 26, 2025 00:21
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 25, 2025 16:45
@github-actions github-actions bot added size:l [PR only] 101-1000 LoC changed and removed size:m [PR only] 25-100 LoC changed labels Jan 25, 2025
@caugner caugner self-requested a review January 28, 2025 13:38
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@caugner caugner merged commit a5c4755 into mdn:main Jan 28, 2025
7 checks passed
@mdn-bot mdn-bot mentioned this pull request Jan 28, 2025
@skyclouds2001 skyclouds2001 deleted the Request.init.duplex branch January 28, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants