Add Document member support notes for Safari #25621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes some fixes where current data was wrong: - `alinkColor`, `designMode`, `scripts` were already added in Safari 1. - `write` was only fixed in Safari 11.
github-actions
bot
added
data:api
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
caugner
commented
Jan 9, 2025
There was a problem hiding this comment.
Flat diff:
[^n1]: "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument), not all `Document` objects."
[^n41]: "Only supported for [`HTMLDocument`](https://developer.mozilla.org/docs/Web/API/HTMLDocument) and `XMLDocument`, but not `SVGDocument` objects."
Elchi3
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For every
Documentmember that, in some Safari versions, is only exposed toHTMLDocument(and not also toSVGDocumentandXMLDocument), ensures that there is a corresponding note.Test results and supporting details
Source: https://github.com/caugner/document-members/blob/main/SUMMARY.md#safari
This includes some fixes where current data was wrong:
alinkColor,designMode,scriptswere already added in Safari 1.writewas only fixed in Safari 11.Related issues
Part of #10682.