Set values for IE/Edge for JavaScript Intl #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
added
the
data:js 📟
Elchi3
requested changes
Sep 9, 2019
There was a problem hiding this comment.
Caniuse says "Intl.PluralRules exists, but methods are not implemented." https://caniuse.com/#feat=intl-pluralrules
I would mark it as false maybe with the same note on the object.
|
Hmm... I question the validity of CanIUse's data, as all the methods I've tested are implemented. Furthermore, it appears that an example using locales functions as expected in Edge 18:
|
|
It is indeed implemented in chakra! chakra-core/ChakraCore#4940 |
Elchi3
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets all the IE and Edge JavaScript values for the Intl built-ins (and corresponding Array.toLocaleString entries) based upon manual testing, or mirroring IE data onto Edge. Data is as follows:
javascript.builtins.Array.toLocaleString.locales - false
javascript.builtins.Array.toLocaleString.options - false
javascript.builtins.Intl - already 11 in IE
javascript.builtins.Intl.Collator.caseFirst - false
javascript.builtins.Intl.Collator.compare - already 11 in IE
javascript.builtins.Intl.Collator.prototype - already 11 in IE
javascript.builtins.Intl.Collator.resolvedOptions - already 11 in IE
javascript.builtins.Intl.Collator.supportedLocalesOf - already 11 in IE
javascript.builtins.Intl.DateTimeFormat.hourCycle - 18
javascript.builtins.Intl.DateTimeFormat.iana_time_zone_names - 14
javascript.builtins.Intl.DateTimeFormat.prototype - already 11 in IE
javascript.builtins.Intl.DateTimeFormat.supportedLocalesOf - already 11 in IE
javascript.builtins.Intl.NumberFormat.format - already 11 in IE
javascript.builtins.Intl.NumberFormat.formatToParts - 11
javascript.builtins.Intl.NumberFormat.prototype - already 11 in IE
javascript.builtins.Intl.NumberFormat.supportedLocalesOf - already 11 in IE
javascript.builtins.Intl.PluralRules.PluralRules - 18
javascript.builtins.Intl.PluralRules.prototype - 18
javascript.builtins.Intl.PluralRules.resolvedOptions - 18
javascript.builtins.Intl.PluralRules.select - 18
javascript.builtins.Intl.PluralRules.supportedLocalesOf - 18