Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(github): Add missing labels to .github/labels.yml #4806

Merged
merged 3 commits into from
Sep 11, 2019
Merged

chore(github): Add missing labels to .github/labels.yml #4806

merged 3 commits into from
Sep 11, 2019

Conversation

ExE-Boss
Copy link
Contributor

This adds the infra 🏗 and schema ⚙️ labels to the .github/labels.yml file.

@ExE-Boss ExE-Boss force-pushed the github/labels/add-missing branch 3 times, most recently from 9153017 to 24f571f Compare September 10, 2019 20:20
@queengooborg queengooborg added the infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project label Sep 10, 2019
ddbeck
ddbeck requested changes Sep 11, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this config update, @ExE-Boss. This is a good idea. I had a couple of suggestions to build on this.

.github/labels.yml Show resolved Hide resolved
.github/labels.yml Outdated Show resolved Hide resolved
ddbeck
ddbeck approved these changes Sep 11, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit e0d00e5 into mdn:master Sep 11, 2019
@ExE-Boss ExE-Boss deleted the github/labels/add-missing branch September 11, 2019 16:56
@Elchi3 Elchi3 removed their request for review January 8, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ExE-Boss @ddbeck @queengooborg