Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New compatibility data for theme_experiment #4878

Merged
merged 1 commit into from
Sep 27, 2019
Merged

New compatibility data for theme_experiment #4878

merged 1 commit into from
Sep 27, 2019

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Sep 24, 2019

This is new compatibility data for the theme_experiment manifest key. In addition to linting, also verified in local copy of Kumascript. Details of the new key are in https://bugzilla.mozilla.org/show_bug.cgi?id=1347207

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@rebloor rebloor requested a review from irenesmith as a code owner September 24, 2019 18:10
@ghost ghost added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 24, 2019
irenesmith
irenesmith approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@irenesmith irenesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenesmith irenesmith merged commit 1b5bd1a into mdn:master Sep 27, 2019
@rebloor rebloor deleted the theme-experiment branch October 1, 2019 15:44
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenesmith irenesmith irenesmith approved these changes

Assignees
No one assigned
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebloor @irenesmith