Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize styling for linters #5030

Merged
merged 5 commits into from
Oct 29, 2019
Merged

Standardize styling for linters #5030

merged 5 commits into from
Oct 29, 2019

Conversation

queengooborg
Copy link
Contributor

This PR provides a little standardization of linter styling to maintain consistency across the linter output. This provides a few updates:

  • Adds a "→" for bullet points for each error
  • Fixes the use of bold in test-schema.js
  • Adds coloring to a statement initially lacking any

@queengooborg queengooborg requested a review from Elchi3 as a code owner October 24, 2019 10:55
@ghost ghost added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Oct 24, 2019
Elchi3
Elchi3 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This works 👍

@Elchi3 Elchi3 merged commit a310b15 into mdn:master Oct 29, 2019
@queengooborg queengooborg deleted the linter/styling branch October 29, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3