Fix ESLint errors + JSDoc comments for scripts/ #5654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
bulk_update
queengooborg
added
the
scripts
ExE-Boss
suggested changes
Feb 7, 2020
|
This PR appears to partly relate to #5252 and #5635 (comment). Like #5655, I'd suggest closing this and breaking it into separate PRs. There's a few things that this PR changes which don't seem strictly related: JSDoc comments, whether scripts should be executable, and copyright notices. It'd be a lot easier to review them separately. Thank you! |
|
Sounds good to me, I'll start breaking this down then! I'll mark this as "not ready" and leave it open until the separate PRs have been created. |
queengooborg
added
the
not ready
This was referenced Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up the issues reported by ESLint, as well as updates the JSDoc comments, and performs just a little bit of refactoring for efficiency and consistency in the scripts files.