Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme_experiment.json #5800

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Update theme_experiment.json #5800

merged 3 commits into from
Mar 12, 2020

Conversation

bershanskiy
Copy link
Contributor

Changes

  1. Mark WebExtension manifest key theme_experiment is experimental, non-standard. (See the article for details).
  2. Remove redundant MDN URLs

This is related to #5273, since removes MDN URLs that don't match the regular pattern. If these URLs should be kept, just tell me and I'll drop the second commit (and update #5273 accordingly).

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

WebExtension manifest key theme_experiment is experimental, non-standard.
@ghost ghost added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Mar 9, 2020
@rebloor
Copy link
Collaborator

rebloor commented Mar 10, 2020

@bershanskiy Thanks for this. However, I would ask that we retain the linked URLs. While they may be redundant on the theme_experiment API page, we published the compatibility table on the browser API support page where they are not redundant.

This reverts commit f2bdc50,
as per review.
@bershanskiy
Copy link
Contributor Author

@rebloor

I would ask that we retain the linked URLs.

Thanks for explanation, I reverted that commit.

@rebloor rebloor merged commit 5ccc39a into mdn:master Mar 12, 2020
@rebloor
Copy link
Collaborator

rebloor commented Mar 12, 2020

Thanks @bershanskiy

@bershanskiy bershanskiy deleted the webextensions.manifest.theme_experiment branch May 8, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants