Revert nodejs version bump #5863
Conversation
ghost
added
dependencies ⛓️
There was a problem hiding this comment.
Yes, let's revert and re-release. One minor line suggestion.
More broadly, I don't think it's worth doing a major version release solely for the configuration change, but if at some point we want to use some Node feature from v10, then we should go ahead and bump the version then. In other words, I don't think it's appropriate to go out of our way for v8 compatibility, but as long as it doesn't cost us anything, there's no reason to force a breakage on v8 users.
Co-Authored-By: Daniel D. Beck <daniel@ddbeck.com>
Do you mean something special when saying "re-release"? I thought releasing the next subsequent patch version (1.0.14) would be fine?
Yes, completely agree to this. |
Sorry, no, I just meant "release 1.0.14." I kinda interpreted this PR as fixing the breakage and then issuing a 1.0.14 release as soon as this is merged. But we could just do the 1.0.14 release at the usual time. Regardless, I'm going to add a notice to the 1.0.13 release notes to mention that the release is broken for Node v8 users. (I guess I should recap this discussion on #5852 as well.) |
Apparently, we are breaking packages by bumping our engine version. I think this isn't our goal, so I propose we revert this and release 1.0.14 with the old requirements.
Alternatively, we could leave it in (and release 2.0.0 to properly communicate it) and ask people to definitely use a higher nodejs versions, but this won't work for people that are forced use older nodejs versions for longer (which apparently happens as reported here #5852 (comment))