Create function to run "global" linters #5939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
linter
23 tasks
|
Hey Vinyl, thank you for this PR. I'm grateful that you gave this some thought and considered how to improve things. That said, I think the proposal to adopt Mocha (see #6855) is going to obviate the need for a lot of this. This a similar theme to Florian's comment on #5300—breaking testing out separately from linting. For instance, I foresee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was cherry-picked from #5300 to combine our "global" tests into one function with a structure similar to the file testing function, including using the ora spinner, and basing the error count off of console errors instead of return values.
In #5300 (comment), it was also suggested that a different name besides "global test" is used. Perhaps "non-data"?