Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: text-underline-offset in development in chrome #6753

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

manuelmeister
Copy link
Contributor

Added spec url and status of chrome

https://www.w3.org/TR/css-text-decor-4/#underline-offset
https://chromestatus.com/feature/5747636764147712

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Sep 23, 2020
Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s exciting to know this feature’s in active development in Chrome, but I think we might need to consider waiting for it actually ship in a Chrome release before we update BCD for it. Let’s see what @ddbeck has to say.

css/properties/text-underline-offset.json Outdated Show resolved Hide resolved
css/properties/text-underline-offset.json Outdated Show resolved Hide resolved
css/properties/text-underline-offset.json Outdated Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 24, 2020

Oh I just saw that this is your first BCD PR, @manuelmeister! Thank you and welcome!

manuelmeister and others added 2 commits September 28, 2020 08:26
… quite fast

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
@sideshowbarker sideshowbarker merged commit 14804b9 into mdn:master Sep 28, 2020
@sideshowbarker
Copy link
Member

@manuelmeister Thanks much, and welcome to the MDN browser-compat-data project 🎉

@manuelmeister manuelmeister deleted the patch-1 branch September 29, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants