Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version_added for ReadableStreamBYOB* #6939

Merged
merged 2 commits into from
May 20, 2021
Merged

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Oct 16, 2020

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: closes api.ReadableStreamBYOBReader - Supported on Chrome/Edge #10445

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 16, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 12, 2020

Are sure about these? A couple (admittedly very shallow) searches seem to turn up some evidence that these aren't abandoned features:
https://bugs.chromium.org/p/chromium/issues/detail?id=614302&q=ReadableByteStreamController&can=2
https://bugzilla.mozilla.org/show_bug.cgi?id=1507945

It'd be good to take a closer look—perhaps do a little testing to more strongly confirm non-implementation—before merging this.

@domenic
Copy link
Contributor

domenic commented Nov 12, 2020

Indeed, these are currently being implemented in Chromium, targeting a release or two from now.

@saschanaz saschanaz marked this pull request as draft November 12, 2020 14:39
Base automatically changed from master to main March 24, 2021 12:54
@saschanaz saschanaz changed the title Remove never-supported Streams APIs Add version_added for ReadableStreamBYOB* May 11, 2021
@saschanaz saschanaz marked this pull request as ready for review May 11, 2021 22:15
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status entry says this also shipped on WebView. Would you mind setting the same version for that browser too? https://chromestatus.com/feature/4535319661641728 Thank you!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit b3d2423 into mdn:main May 20, 2021
@saschanaz saschanaz deleted the nosupport-streams branch May 20, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api.ReadableStreamBYOBReader - Supported on Chrome/Edge
4 participants