Correct Chrome data for HTMLIFrameElement API #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
foolip
approved these changes
Nov 3, 2020
| }, | ||
| "chrome_android": { | ||
| "version_added": "18" | ||
| "version_added": "25" |
There was a problem hiding this comment.
This is srcdoc, and this (and the mirrored data) is the only change in the PR that increases the version_added. This came from #1356 which just bumped the version number from "4", and "4" came from wiki migration in #2017, so I see no reason to especially trust it. srcdoc is not a feature that I can see being per-platform, it's deep inside HTML.
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Jul 19, 2024
This was implemented without a flag, and with the reflected IDL attribute, in WebKit 532.6: WebKit/WebKit@c205c4e https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly earlier updates based on collector test results: mdn#7243 mdn#7290 mdn#7402 The handled attribute tokens were "allow-same-origin", "allow-forms", and "allow-scripts", so update that data to match.
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Jul 19, 2024
This was implemented without a flag, and with the reflected IDL attribute, in WebKit 532.6: WebKit/WebKit@c205c4e https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly earlier updates based on collector test results: mdn#7243 mdn#7290 mdn#7402 The handled attribute tokens were "allow-same-origin", "allow-forms", and "allow-scripts", so update that data to match. The "allow-popups" entry was bumped to pass the lint.
Elchi3
pushed a commit
that referenced
this pull request
Jul 22, 2024
This was implemented without a flag, and with the reflected IDL attribute, in WebKit 532.6: WebKit/WebKit@c205c4e https://github.com/WebKit/WebKit/blob/c205c4e7d40da38c5009df548c2316a358a4fca7/WebCore/Configurations/Version.xcconfig That maps to Chrome 5 + Safari 5 + iOS 4, which also matches exactly earlier updates based on collector test results: #7243 #7290 #7402 The handled attribute tokens were "allow-same-origin", "allow-forms", and "allow-scripts", so update that data to match. The "allow-popups" entry was bumped to pass the lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the Chrome data for the HTML
<iframe>element API based upon results from the mdn-bcd-collector project (using results from Chrome 1-86 and Opera 12.14, 15, and 70). Most of the data was set to "Chrome 43"; however, from my testing, I've found that Chrome 43 was a magic number of when all properties are initialized on the object prototype. (Thus, it's best not to trust results that indicate Chrome 43 as much.)