Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CSS pseudo-class :-moz-ui-invalid to :user-invalid #7431

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Rename CSS pseudo-class :-moz-ui-invalid to :user-invalid #7431

merged 4 commits into from
Nov 24, 2020

Conversation

rachelandrew
Copy link
Collaborator

Working on mdn/sprints#1686

I have moved the non-standard -moz-ui-invalid page to the standard user-invalid. This PR created BCD for :user-invalid with -moz-ui-invalid as an alternate name. Then deletes -moz-ui-invalid

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 20, 2020
Elchi3
Elchi3 requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit and one structural thing. Looks good to me otherwise

css/selectors/user-invalid.json Outdated Show resolved Hide resolved
css/selectors/user-invalid.json Outdated Show resolved Hide resolved
rachelandrew and others added 3 commits November 24, 2020 05:08
@rachelandrew @Elchi3
Update css/selectors/user-invalid.json
54e48ee 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@rachelandrew
removing false statement
b1b593d
@rachelandrew
fix
06f2f74
Elchi3
Elchi3 approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rachel! 👍

@Elchi3 Elchi3 merged commit 638069c into mdn:master Nov 24, 2020
@ddbeck ddbeck changed the title user-invalid pseudo Rename CSS pseudo-class :-moz-ui-invalid to :user-invalid Nov 25, 2020
@GPHemsley GPHemsley mentioned this pull request Jan 17, 2022
Open
@bsmth bsmth mentioned this pull request Jun 12, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelandrew @Elchi3 @ddbeck