Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename api.HTMLElement.formEncType -> formEnctype #7471

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

queengooborg
Copy link
Collaborator

This PR fixes a capitalization issue for the HTMLElement API's formEnctype method. Inspired by #7402 (comment).

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 23, 2020
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLInputElement/formEncType",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLInputElement/formEnctype",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this and the old URL is 404. @ddbeck should we include the URLs in this case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dealing with 404s is a whole… thing. #5297 is open to remove them, but there's some process questions around that (how do we pick up those pages once they're created?) that are unanswered. For now, I suggest keeping the 404s.

@foolip
Copy link
Collaborator

foolip commented Nov 23, 2020

@vinyldarkscratch can you update https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement as well once this is ready to merge?

@queengooborg
Copy link
Collaborator Author

Certainly, can do!

@foolip foolip requested a review from ddbeck November 24, 2020 13:55
@foolip
Copy link
Collaborator

foolip commented Nov 24, 2020

So after @ddbeck's guidance #7472 I think I can deal with this myself. I've updated MDN in https://wiki.developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement$compare?to=1655071&from=1641293 and since https://developer.mozilla.org/docs/Web/API/HTMLInputElement/formEnctype doesn't exist, nothing more will need to be done for the next release.

I'll go ahead and merge this now.

@foolip foolip merged commit d2469e2 into mdn:master Nov 24, 2020
@queengooborg queengooborg deleted the api/HTMLElement-formEnctype branch November 24, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants