Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce @viewport to main feature; mark removal/deprecation #7514

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

rachelandrew
Copy link
Collaborator

Updating BCD for deprecated @viewport as described in mdn/sprints#3404 (comment)

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 27, 2020
@Elchi3
Copy link
Member

Elchi3 commented Nov 27, 2020

I think reducing this to just the @viewport main feature is fine even if the sub features don't yet meet the removal requirements. (not yet 2 years gone per https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#removal-of-irrelevant-features)

The only blocking thing would be to do something with the MDN sub pages like
https://developer.mozilla.org/en-US/docs/Web/CSS/@viewport/max-width

Should we redirect these to https://developer.mozilla.org/en-US/docs/Web/CSS/@viewport?

@rachelandrew
Copy link
Collaborator Author

Should we redirect these to https://developer.mozilla.org/en-US/docs/Web/CSS/@viewport?

that would make sense to me, I don't think I can redirect or I would do it. I can move pages but that's all.

@Elchi3
Copy link
Member

Elchi3 commented Nov 27, 2020

I've put the redirects in place for all sub pages of @viewport (there is a button in ckeditor, maybe it requires permissions?)

See https://wiki.developer.mozilla.org/en-US/docs/Web/CSS/@viewport/zoom$compare?locale=en-US&to=1655328&from=1645709 for how the change looks like.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also set the removal versions in Edge and Operas to signal that this is really gone, but we can also do that in a follow-up.

A question about standards track but otherwise LGTM.

css/at-rules/viewport.json Outdated Show resolved Hide resolved
@Elchi3 Elchi3 changed the title update @viewport Reduce @viewport to main feature; mark removal/deprecation Nov 27, 2020
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rachel! 👍

@Elchi3 Elchi3 merged commit ee35543 into mdn:master Nov 30, 2020
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Apr 27, 2021
In mdn#7514
(mdn@c0e0e2b)
we removed data for the viewport-fit descriptor from BCD.
So this change drops corresponding spec URL for the definition
of the viewport-fit descriptor in the CSS Round Display spec.
Elchi3 pushed a commit that referenced this pull request Apr 27, 2021
In #7514
(c0e0e2b)
we removed data for the viewport-fit descriptor from BCD.
So this change drops corresponding spec URL for the definition
of the viewport-fit descriptor in the CSS Round Display spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants