Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a public API and SemVer policy #7615

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Dec 8, 2020

This recasts the list of data folders as the public API for @mdn/browser-compat-data and explicitly names it as such for the purposes of a semantic versioning policy. This fixes #7563.

The diff here is a bit ugly. You may want to use the split or rich diffs to review this one. You can also view the full README rendered on my fork.

@github-actions github-actions bot added the docs ✍️ Issues or pull requests regarding the documentation of this project. label Dec 8, 2020
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel, this captures nicely what we talked about!

I think we ought to explicitly protect the webextensions branches, given there is Mozilla WebExtension tooling that consumes BCD specifically for that.

Looks good to me otherwise.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ddbeck
Copy link
Collaborator Author

ddbeck commented Dec 9, 2020

Thanks for the eagle-eyed copy edits, @sideshowbarker!

@Elchi3 I've expanded the list for WebExtensions. Good catch!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 💯

@ddbeck
Copy link
Collaborator Author

ddbeck commented Dec 10, 2020

@jpmedley You asked to have a look at this during the editorial meeting. Since I plan to follow this policy for today's release (which will be a semver major release), I plan to merge this before the release today (probably around 8-10am PST). If you don't get a chance to look at this before I merge, I'd still like your feedback. Thank you!

@ddbeck ddbeck merged commit de379a8 into mdn:master Dec 10, 2020
@ddbeck ddbeck deleted the semver-policy branch December 10, 2020 16:50
@jpmedley
Copy link
Contributor

It looks fine to me. I should have been clear that I wasn't interested in giving feedback. I was interested in possible consequences to a tool that I built that consumes this data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt better SemVer practices
5 participants