Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt CookieStore change event to new structure #12913

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Adapt CookieStore change event to new structure #12913

merged 1 commit into from
Feb 11, 2022

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Feb 11, 2022

This PR updates the change event of the CookieStore API to the new format, loosely based on the events template.

BCD PR: mdn/browser-compat-data#14934

@queengooborg queengooborg requested review from a team as code owners February 11, 2022 15:38
@queengooborg queengooborg requested review from jpmedley and ddbeck and removed request for a team February 11, 2022 15:38
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 11, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/CookieStore
Title: CookieStore
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/CookieStore/change_event
Title: CookieStore: change event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.CookieStore.change_event

External URLs

URL: /en-US/docs/Web/API/CookieStore
Title: CookieStore
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/CookieStore/change_event
Title: CookieStore: change event
on GitHub

No new external URLs

@jpmedley
Copy link
Collaborator

@ddbeck I have misplaced the instructions for how we do events now. Can you please send them to me again so that I can review this?

@queengooborg
Copy link
Collaborator Author

@jpmedley The following discussion contains the information I believe you're looking for: https://github.com/mdn/content/discussions/9098#discussioncomment-2140424

@jpmedley
Copy link
Collaborator

Thanks!

@jpmedley jpmedley merged commit b5b5322 into mdn:main Feb 11, 2022
@queengooborg queengooborg deleted the cookiestore/change_event branch February 11, 2022 16:28
@queengooborg
Copy link
Collaborator Author

Thanks for reviewing and merging, @jpmedley! Can you also review the corresponding BCD PR?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants