Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt AudioScheduledSourceNode ended event to new structure #12972

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Adapt AudioScheduledSourceNode ended event to new structure #12972

merged 1 commit into from
Feb 14, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR updates the ended event of the AudioScheduledSourceNode API to conform to the new structure.

BCD PR: mdn/browser-compat-data#14963

@queengooborg queengooborg requested review from a team as code owners February 14, 2022 01:37
@queengooborg queengooborg requested review from jpmedley and ddbeck and removed request for a team February 14, 2022 01:37
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 14, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/AudioScheduledSourceNode/ended_event
Title: AudioScheduledSourceNode: ended event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/AudioScheduledSourceNode/onended redirects to /en-US/docs/Web/API/AudioScheduledSourceNode/ended_event

External URLs

URL: /en-US/docs/Web/API/AudioScheduledSourceNode/ended_event
Title: AudioScheduledSourceNode: ended event
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 22e0b3c into mdn:main Feb 14, 2022
@queengooborg queengooborg deleted the api/AudioScheduledSourceNode/ended_event branch February 14, 2022 03:43
@Elchi3
Copy link
Member

Elchi3 commented Feb 14, 2022

@sideshowbarker @queengooborg There are probably a few things to look out for when re-doing event pages. Not sure how to best get into a flow here. Do you need a review checklist or something?

Also @teoli2003 and I try to record the move/redirect commands on the PR, see #12982 or #12597. If there is nothing to redirect, a small comment to say there is no on-* event handler page would be helpful, too.

@queengooborg
Copy link
Collaborator Author

The redirect was actually already performed! I forgot to clean up the old references, though -- will get that fixed, along with standardizing the new events page with the missing sections!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants