Adapt api.Screen.onorientationchange to new events structure

[queengooborg]

This PR adapts the orientationchange event of the Screen API to conform to the new events structure.

BCD PR: mdn/browser-compat-data#15196

[github-actions]

Preview URLs

• https://pr13595.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/CSS_Object_Model/Managing_screen_orientation
• https://pr13595.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Screen/lockOrientation
• https://pr13595.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Screen/orientation
• https://pr13595.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Screen/orientationchange_event
• https://pr13595.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Screen/unlockOrientation
• https://pr13595.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Screen

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Screen
Title: Screen
on GitHub
Flaw count: 4

• macros:
  • wrong xref macro used (consider changing which macro you use)
  • wrong xref macro used (consider changing which macro you use)
  • wrong xref macro used (consider changing which macro you use)
• bad_bcd_links:
  • no explanation!

---

URL: /en-US/docs/Web/API/Screen/orientationchange_event
Title: Screen: orientationchange event
on GitHub
Flaw count: 1

• bad_bcd_queries:
  • No BCD data for query: api.Screen.orientationchange_event

---

URL: /en-US/docs/Web/API/CSS_Object_Model/Managing_screen_orientation
Title: Managing screen orientation
on GitHub
Flaw count: 5

• broken_links:
  • Can't resolve /en-US/docs/Web/API/Detecting_device_orientation
  • Can't resolve /en-US/docs/Mozilla/Firefox_OS
  • Can't resolve /en-US/docs/Mozilla/Firefox_for_Android
  • Can't resolve /en-US/docs/Web/Apps/Build/Manifest#orientation
  • Is currently http:// but can become https://

External URLs

URL: /en-US/docs/Web/API/Screen
Title: Screen
on GitHub

No new external URLs

---

URL: /en-US/docs/Web/API/Screen/orientationchange_event
Title: Screen: orientationchange event
on GitHub

No new external URLs

---

URL: /en-US/docs/Web/API/Screen/unlockOrientation
Title: Screen.unlockOrientation()
on GitHub

No new external URLs

---

URL: /en-US/docs/Web/API/Screen/lockOrientation
Title: Screen.lockOrientation()
on GitHub

No new external URLs

---

URL: /en-US/docs/Web/API/Screen/orientation
Title: Screen.orientation
on GitHub

No new external URLs

---

URL: /en-US/docs/Web/API/CSS_Object_Model/Managing_screen_orientation
Title: Managing screen orientation
on GitHub

No new external URLs

(this comment was updated 2022-03-07 15:44:56.274164)

[teoli2003]

Checklist I used for reviewing this event Content PR:

When onXYZ exists, for each onXYZ

• Redirect from /Web/API/xxxx/onXYZ to /Web/API/xxxx/XYZ_event` set
• /Web/API/xxxx/onXYZ deleted.
• In /Web/API/xxxx/XYZ_event:
  • Front-runner YAML: Correct browser-compat front-runner key
  • Front-runner YAML: Correct title front-runner key to: Interface: XYZ event (with ticks!)
  • Front-runner YAML: No Property and Event Handler int the tag list but Event in it (more cleaning possible)
  • Check if the event bubbles. If not, no mention in article
  • Intro explain the event itself and no more just onXYZ.

    Example: "The levelchange event of the Battery Status API is fired when the battery {{domxref("BatteryManager.level","level")}} property is updated."

  • No HTML table with Bubbles, Cancelable, and Interface lines.
  • Syntax section with the structure of the template, and fix the names of event and of the onXYZ property
  • If inheritance is not only Event, there is an Event type section (two texts possible!, with
    • {{InheritanceDiagram}} with the right argument
    • There is an Event properties section and list the parameters, taken from the interface of the event type
  • Check that no mention of this onXYZ is a link.
  • Check that links to other onXYZ are links to the corresponding XYZ_event

On the API interface page:

• There is no Event handlers section
• There is an Events section (with the correct events)
• Check that there are no links to onXYZ.

On each page of the interface and the API overview page:

• Check that there are no links to onXYZ.
• Check that examples uses the modern syntax for defining function in event handler (onXYZ = event => { …} )
• Check that no {{event} macro is left.
• Fix flaws (as much as possible); at least, make sure not to introduce new flaws.
• Check that if an event is linked to a property value, that property documents when this event is fired.

  Example: "When its value changes, the chargingchange event is fired."

Optional:

• Remove gremlins (non-breaking spaces, curly tick, curly double-ticks)
• If the interface is no more experimental, remove the experimental tags/banners.

Administration:

• Link to the BCD PR.

[teoli2003]

Thanks a lot. A few small changes and we are good to go!

[teoli2003]

👍