-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More guidance about examples #15894
More guidance about examples #15894
Conversation
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL:
URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2022-06-14 04:36:25.009077) |
Thank you for opening this much required PR, @wbamberg! Apologies for not looking at it sooner. |
files/en-us/mdn/structures/page_types/css_property_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/css_selector_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/html_element_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/http_header_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/svg_element_page_template/index.md
Outdated
Show resolved
Hide resolved
I like your proposal @wbamberg in those two scenarios for linking to other examples. |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Thanks for your review, @dipikabh ! I have had a go at writing up rules for linking to external examples. For the time being I've only updated one page: https://pr15894.content.dev.mdn.mozit.cloud/en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template#examples thinking that once we are both happy with those words I can copy it to the other templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit (at several places) and I think it is good to go.
(Approving as these are optional nits)
files/en-us/mdn/structures/page_types/api_event_subpage_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/api_property_subpage_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/api_reference_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/aria_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/css_property_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/css_selector_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/html_element_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/http_header_page_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/svg_element_page_template/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, @wbamberg and for adding content for external examples!!
I've added my suggestions for linking to external examples bit.
files/en-us/mdn/structures/page_types/api_constructor_subpage_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/api_constructor_subpage_template/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mdn/structures/page_types/api_constructor_subpage_template/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess @wbamberg wanted to copy the 'external examples' note in other template pages. Guess he'll open a new PR when he's back. We can close this for now. Thanks for the fixes, @teoli2003!
@dipikabh , @teoli2003 , here's an attempt to update the meta-docs to be more prescriptive about examples.
In particular, I want to:
I removed the bit about linking to examples that live elsewhere, but maybe should put it back as it is probably legitimate sometimes. But I'm not sure how to work that into this structure. An H3
### More examples
? But what if there are only examples that live elsewhere?Maybe:
## Examples
, with no H3s### More examples
?