Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove var from TypedArray methods #17790

Merged
merged 14 commits into from Jun 29, 2022
Merged

Remove var from TypedArray methods #17790

merged 14 commits into from Jun 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2022

Summary

Removes all usage of var from all methods in TypedArray.

Motivation

Modern code examples.

Supporting details

N/A.

Related issues

Part of #16614

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@ghost ghost self-requested a review as a code owner June 29, 2022 23:16
@ghost ghost requested review from Josh-Cena and removed request for a team June 29, 2022 23:16
@github-actions github-actions bot added the Content:JS JavaScript docs label Jun 29, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/indexOf
Title: TypedArray.prototype.indexOf()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reduce
Title: TypedArray.prototype.reduce()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/toString
Title: TypedArray.prototype.toString()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reverse
Title: TypedArray.prototype.reverse()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/length
Title: TypedArray.prototype.length
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/join
Title: TypedArray.prototype.join()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/@@iterator
Title: TypedArray.prototype[@@iterator]()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/toLocaleString
Title: TypedArray.prototype.toLocaleString()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/keys
Title: TypedArray.prototype.keys()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reduceRight
Title: TypedArray.prototype.reduceRight()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/set
Title: TypedArray.prototype.set()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/lastIndexOf
Title: TypedArray.prototype.lastIndexOf()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/subarray
Title: TypedArray.prototype.subarray()
on GitHub

No new external URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me, thank you @phosra !

@wbamberg wbamberg merged commit c6136bb into mdn:main Jun 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant