Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix touch events from GlobalEventHandlers #18110

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Demix touch events from GlobalEventHandlers #18110

merged 1 commit into from
Jul 8, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the ontouch* event handlers from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16759

@queengooborg queengooborg requested review from a team as code owners July 8, 2022 06:50
@queengooborg queengooborg requested review from wbamberg and removed request for a team July 8, 2022 06:50
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Element/touchcancel_event
Title: Element: touchcancel event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/touchmove_event
Title: Element: touchmove event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/touchend_event
Title: Element: touchend event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/touchstart_event
Title: Element: touchstart event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 26

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockchange does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockerror does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onratechange does not exist
    • and 10 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/Document/touchcancel_event
Title: Document: touchcancel event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/Document/touchmove_event
Title: Document: touchmove event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/Document/touchend_event
Title: Document: touchend event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/Document/touchstart_event
Title: Document: touchstart event
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/API/TouchEvent
Title: TouchEvent
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

External URLs

URL: /en-US/docs/Web/API/Element/touchcancel_event
Title: Element: touchcancel event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element/touchmove_event
Title: Element: touchmove event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element/touchend_event
Title: Element: touchend event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element/touchstart_event
Title: Element: touchstart event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs


URL: /en-US/docs/Web/API/Document/touchcancel_event
Title: Document: touchcancel event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/touchmove_event
Title: Document: touchmove event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/touchend_event
Title: Document: touchend event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/touchstart_event
Title: Document: touchstart event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/TouchEvent
Title: TouchEvent
on GitHub

@teoli2003 teoli2003 merged commit a361362 into mdn:main Jul 8, 2022
@queengooborg queengooborg deleted the ontouch branch July 8, 2022 23:09
@Elchi3
Copy link
Member

Elchi3 commented Sep 1, 2022

This PR updated the Document touch events. I'm not sure why.

In the BCD PR, only the touch events on Element were kept and everything else was removed. mdn/browser-compat-data#16759 (review)

This leaves the following MDN pages without compat tables:
https://developer.mozilla.org/en-US/docs/Web/API/Document/touchcancel_event
https://developer.mozilla.org/en-US/docs/Web/API/Document/touchmove_event
https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event
https://developer.mozilla.org/en-US/docs/Web/API/Document/touchstart_event

I will file a PR to remove and redirect touch event pages on Document to Element.
Let me know if I misunderstood what was the plan behind this event pages reorg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants