Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var -> const #18221

Merged
merged 2 commits into from
Jul 11, 2022
Merged

var -> const #18221

merged 2 commits into from
Jul 11, 2022

Conversation

Josh-Cena
Copy link
Member

Summary

Motivation

Part of #16614 — we're almost there.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Josh-Cena Josh-Cena requested a review from a team as a code owner July 11, 2022 11:47
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team July 11, 2022 11:47
@github-actions github-actions bot added the Content:JS JavaScript docs label Jul 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 16 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Errors/No_non-null_object
Title: TypeError: "x" is not a non-null object
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Errors/More_arguments_needed
Title: TypeError: More arguments needed
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_toLocaleFormat
Title: Warning: Date.prototype.toLocaleFormat is deprecated
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat does not exist
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat does not exist

URL: /en-US/docs/Web/JavaScript/Reference/Errors/in_operator_no_object
Title: TypeError: cannot use 'in' operator to search for 'x' in 'y'
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Identifier_after_number
Title: SyntaxError: identifier starts immediately after numeric literal
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Missing_curly_after_property_list
Title: SyntaxError: missing } after property list
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/No_non-null_object
Title: TypeError: "x" is not a non-null object
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Not_defined
Title: ReferenceError: "x" is not defined
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/More_arguments_needed
Title: TypeError: More arguments needed
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_toLocaleFormat
Title: Warning: Date.prototype.toLocaleFormat is deprecated
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Missing_semicolon_before_statement
Title: SyntaxError: missing ; before statement
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Invalid_for-in_initializer
Title: SyntaxError: for-in loop head declarations may not have initializers
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/invalid_right_hand_side_instanceof_operand
Title: TypeError: invalid 'instanceof' operand 'x'
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Non_configurable_array_element
Title: TypeError: can't delete non-configurable array element
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Illegal_character
Title: SyntaxError: illegal character
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Not_a_constructor
Title: TypeError: "x" is not a constructor
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Invalid_assignment_left-hand_side
Title: ReferenceError: invalid assignment left-hand side
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Missing_bracket_after_list
Title: SyntaxError: missing ] after element list
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/in_operator_no_object
Title: TypeError: cannot use 'in' operator to search for 'x' in 'y'
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Missing_curly_after_function_body
Title: SyntaxError: missing } after function body
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Invalid_for-of_initializer
Title: SyntaxError: a declaration in the head of a for-of loop can't have an initializer
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Missing_colon_after_property_id
Title: SyntaxError: missing : after property id
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Malformed_formal_parameter
Title: SyntaxError: Malformed formal parameter
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Missing_name_after_dot_operator
Title: SyntaxError: missing name after . operator
on GitHub

No new external URLs

(this comment was updated 2022-07-11 12:26:25.657799)

teoli2003
teoli2003 suggested changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typographic detail, and this is good to go!

files/en-us/web/javascript/reference/errors/invalid_for-in_initializer/index.md Outdated Show resolved Hide resolved
@Josh-Cena @teoli2003
Update files/en-us/web/javascript/reference/errors/invalid_for-in_ini…
e062805 
…tializer/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@teoli2003 teoli2003 merged commit b260451 into mdn:main Jul 11, 2022
@Josh-Cena Josh-Cena deleted the var-const branch July 11, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @teoli2003