-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove outdated hgroup content #18530
Conversation
The [`<hgroup>` element](https://html.spec.whatwg.org/multipage/sections.html#the-hgroup-element) was recently significantly revised in the HTML specification. The warnings about its impact on the outline algorithm are no longer relevant, as the concept of the outline algorithm was removed from the HTML specification as well. This PR simply removes outdated content, and replaces the remaining bits with content that is more inline with the current definition for the element.
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
can anyone explain what these 'flaws' are about? if i'm reading this right, they're largely related to references to other HTML elements which i didn't touch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge thank you!
The flaws were in the page and are not due to your edits. A macro in the page pulls in content that has links to h1-h6 pages which have entries in the _redirects.txt to a single 'heading_elements' page. When there is a link that leads to a redirect it is a 'flaw' not an error, since the link will still work. Hope that helps. |
@estelle what's the general turnaround time for this to appear on the mdn website? |
The production Web site is usually built once a day; read this section for more information. |
The
<hgroup>
element was recently significantly revised in the HTML specification. The warnings about its impact on the outline algorithm are no longer relevant, as the concept of the outline algorithm was removed from the HTML specification as well.This PR simply removes outdated content, and replaces the remaining bits with content that is more inline with the current definition for the element.
Note: I anticipate that there may be other things that people might want to call out for this element. That'd make sense. My primary goal here was to remove no longer valid information. Whether any additional content is added to this PR or a following one makes little difference to me, other than the fact we probably don't want to be misaligned with the HTML spec for too long.
Oh yeh, and this closes #11153
This PR…