ci(pr-test): use GitHub API to get changed files + diff #21305
Conversation
There was a problem hiding this comment.
Let's wait until mdn/translated-content#8952 has landed and works without issues.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
caugner
changed the title
|
A test workflow run is here: https://github.com/mdn/content/actions/runs/3635116130/jobs/6133911927 Also poke @bsmth for typo check :) |
I'm happy to take a look after the requested changes are applied. Please |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
| - name: Validate redirects | ||
| if: ${{ env.GIT_DIFF_REDIRECTS }} | ||
| run: | |
There was a problem hiding this comment.
A bit confused here. We have redirect check workflow. So should we remove this part or remove that workflow?
There was a problem hiding this comment.
The other call is slightly different, but I was also wondering about this call. I'd usually suggest the separate call, unless there actually is a benefit of running it after a build
There was a problem hiding this comment.
Yeah, let's keep it for now. The "redirect check" workflow is more strict, so in theory it should always also fail if this non-strict call (which just loads the file) fails. But I think it's a separate conversion, outside of the scope of this PR. 🙂
Also disables the workflow on the main branch, as this workaround seems no longer necessary.
Description
Reflect of mdn/translated-content#8952. Try to speed up the PR test workflow.
Additional details
Please see the original PR: mdn/translated-content#8952.