Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding let when declaring a variable so it's consistent with other ex… #2153

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Adding let when declaring a variable so it's consistent with other ex… #2153

merged 1 commit into from
Feb 8, 2021

Conversation

avivmu
Copy link
Contributor

@avivmu avivmu commented Feb 7, 2021

…amples

@avivmu avivmu requested review from a team and chrisdavidmills and removed request for a team February 7, 2021 20:19
chrisdavidmills
chrisdavidmills approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works fine, as the first attempt to declare bigmouth errors out, so the operation doesn't stick, and the second attempt can then succeed.

@chrisdavidmills chrisdavidmills merged commit 962cc77 into mdn:main Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avivmu @chrisdavidmills