Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CSSLayer*Rule interfaces #24124

Merged
merged 28 commits into from
Mar 15, 2023
Merged

Add missing CSSLayer*Rule interfaces #24124

merged 28 commits into from
Mar 15, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Feb 3, 2023 •
edited
Loading

As part of openwebdocs/project#152, here is the addition of the missing CSSLayerStatementRule and CSSLayerBlockRule parts of the Cascade Layer feature. With this PR, all cascade layers APIs are documented.

Spec link: https://drafts.csswg.org/css-cascade-5/#layer-apis

Capture d’écran 2023-02-03 à 09 32 08

@teoli2003 teoli2003 requested a review from Elchi3 February 3, 2023 08:31
@teoli2003 teoli2003 requested review from a team as code owners February 3, 2023 08:31
@teoli2003 teoli2003 requested review from dipikabh and removed request for a team February 3, 2023 08:31
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-03-15 05:17:12)

@teoli2003 teoli2003 requested a review from a team as a code owner February 3, 2023 08:37
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Feb 3, 2023
estelle
estelle reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more suggestions

files/en-us/web/api/csslayerstatementrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/namelist/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/namelist/index.md Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/namelist/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/namelist/index.md Show resolved Hide resolved
teoli2003 and others added 11 commits February 8, 2023 14:30
@teoli2003 @estelle
Update files/en-us/web/api/csslayerblockrule/index.md
42f0a1c 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerblockrule/name/index.md
af1ba7e 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerblockrule/index.md
72108d2 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/index.md
c30898e 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/index.md
110e8fb 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/index.md
cbe2114 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/index.md
073263d 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/namelist/index.md
94b73ab 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/namelist/index.md
76ad7a6 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/namelist/index.md
4173c9c 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 @estelle
Update files/en-us/web/api/csslayerstatementrule/namelist/index.md
f0106af 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@teoli2003 teoli2003 requested a review from estelle March 2, 2023 15:46
@teoli2003
Copy link
Contributor Author

I think this is good now

@estelle
Copy link
Member

estelle commented Mar 3, 2023

@estelle Note to self: check this.

Elchi3
Elchi3 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. LGTM otherwise

files/en-us/web/api/csslayerblockrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerstatementrule/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/csslayerblockrule/index.md Outdated Show resolved Hide resolved
teoli2003 and others added 4 commits March 14, 2023 17:03
@teoli2003 @Elchi3
Update files/en-us/web/api/csslayerblockrule/index.md
017235e 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 @Elchi3
Update files/en-us/web/api/csslayerstatementrule/index.md
ee3cb8a 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 @Elchi3
Update files/en-us/web/api/csslayerstatementrule/index.md
417e18c 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 @Elchi3
Update files/en-us/web/api/csslayerstatementrule/index.md
3c1a150 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
giftcardvalidator

This comment was marked as spam.

Sign in to view

estelle
estelle approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. the note to myself didn't work ;)

@teoli2003 @Elchi3
Update files/en-us/web/api/csslayerblockrule/index.md
3ee5e21 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003
Copy link
Contributor Author

Sorry for the delay. the note to myself didn't work ;)

No worry, this was not blocking anything.

@teoli2003 teoli2003 merged commit d541534 into mdn:main Mar 15, 2023
@teoli2003 teoli2003 mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giftcardvalidator giftcardvalidator giftcardvalidator left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@estelle estelle estelle approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teoli2003 @estelle @Elchi3 @giftcardvalidator