Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toJSON() to PerformanceTiming and PerformanceNavigation #24126

Merged
merged 5 commits into from
Feb 3, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Feb 3, 2023

I used: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEventTiming/toJSON as the template.

I didn't add an example as:

  • these interfaces are deprecated
  • all properties/methods documented for these interfaces don't have one.

Crafting new examples for these interfaces would have be a loss of time.

This is part of openwebdocs/project#152

@teoli2003 teoli2003 requested a review from Elchi3 February 3, 2023 09:18
@teoli2003 teoli2003 requested a review from a team as a code owner February 3, 2023 09:18
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/API/PerformanceNavigation/toJSON
Title: PerformanceNavigation.toJSON()


URL: /en-US/docs/Web/API/PerformanceTiming/toJSON
Title: PerformanceTiming.toJSON()

(comment last updated: 2023-02-03 12:29:23)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I agree, no need to provide examples here. Some suggestions but otherwise LGTM.

teoli2003 and others added 4 commits February 3, 2023 13:27
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003 teoli2003 requested a review from Elchi3 February 3, 2023 12:27
@Elchi3 Elchi3 merged commit 8689c35 into mdn:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants