Add Request.signal #24465
Merged
Add Request.signal #24465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (comment last updated: 2023-02-16 05:59:47) |
wbamberg
requested changes
Feb 16, 2023
There was a problem hiding this comment.
Looks great except for the comments already made by @dawei-wang :)
(let me know of you would prefer me to just push the suggestions and merge the PR, in cases like this.)
Josh-Cena
reviewed
Feb 16, 2023
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
I like to see the grammar errors (or typos) so I can learn from them. But no worry either way. |
wbamberg
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of openwebdocs/project#152
I added:
Request.signalRequest.The example is not live as it would need a server.