Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServiceWorker.postMessage #24494

Merged
merged 18 commits into from
Feb 17, 2023
Merged

Add ServiceWorker.postMessage #24494

merged 18 commits into from
Feb 17, 2023

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Feb 16, 2023 •
edited by Josh-Cena
Loading

This is part of openwebdocs/project#152

This adds the ServiceWorker.postMessage() and updates a bit two other related pages.

Fix #7593

@teoli2003 teoli2003 requested a review from a team as a code owner February 16, 2023 15:05
@teoli2003 teoli2003 requested review from wbamberg and removed request for a team February 16, 2023 15:05
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-02-17 06:11:11)

@teoli2003 teoli2003 marked this pull request as draft February 16, 2023 15:11
@teoli2003 teoli2003 marked this pull request as ready for review February 16, 2023 15:36
dawei-wang
dawei-wang reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@dawei-wang dawei-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of grammar edits

files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
teoli2003 and others added 2 commits February 16, 2023 20:29
@teoli2003 @dawei-wang
Update files/en-us/web/api/serviceworker/postmessage/index.md
30a1d03 
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
@teoli2003 @dawei-wang
Update files/en-us/web/api/serviceworker/postmessage/index.md
9f6ef3f 
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
@wbamberg
Copy link
Collaborator

I can take a look.

wbamberg
wbamberg requested changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @teoli2003 !

files/en-us/web/api/serviceworker/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/serviceworker/postmessage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/worker/postmessage/index.md Outdated Show resolved Hide resolved
teoli2003 and others added 10 commits February 17, 2023 07:04
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/index.md
37cb866 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/index.md
07e7cad 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/index.md
cba9b0b 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/postmessage/index.md
ad3f122 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/postmessage/index.md
be601f6 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/worker/postmessage/index.md
65b02b0 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/postmessage/index.md
87d3236 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/postmessage/index.md
b550340 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003 @wbamberg
Update files/en-us/web/api/serviceworker/postmessage/index.md
5400acf 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@teoli2003
message -> error
4dfdd12
@teoli2003 teoli2003 requested a review from wbamberg February 17, 2023 06:13
wbamberg
wbamberg approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@wbamberg wbamberg merged commit c571357 into mdn:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawei-wang dawei-wang dawei-wang left review comments

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No docs for the ServiceWorker object’s postMessage method
3 participants
@teoli2003 @wbamberg @dawei-wang