Document SVGClipPathElement.(clipPathUnits|transform) #25340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
sideshowbarker
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create docs for
SVGClipPathElement.clipPathUnitsandSVGClipPathElement.transformMotivation
This is part of openwebdocs/project#152
Additional details
You fall into at least one rabbit hole when you touch the SVG docs. In this case, I had to:
SVGClipPathElementthat was incomplete.SVGUnitTypesthat was old school.SVGAnimatedEnumerationthat was even older school.SVGAnimatedEnumeration.baseValandanimVal.Having practical examples for the latest was not trivial (as animated enumeration is not very interesting to demonstrate).
I didn't fall further into the rabbit hole as I limited myself to what was needed to avoid flaws in these files.
Related issues and pull requests
None.