Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document WritableStreamDefaultController.signal #25566

Merged
merged 12 commits into from
Mar 23, 2023

Conversation

teoli2003
Copy link
Contributor

Description

This adds a page for `WritableStreamDefaultController.signal"

Motivation

This is part of openwebdocs/project#152

Additional details

(Not this was not part of the original list but reached interoperability for all three engines in Q1 2023, so a kind of bonus)

@teoli2003 teoli2003 requested a review from a team as a code owner March 23, 2023 10:11
@teoli2003 teoli2003 requested review from Elchi3 and removed request for a team March 23, 2023 10:11
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Preview URLs

(comment last updated: 2023-03-23 10:51:30)

@teoli2003 teoli2003 changed the title Docuemnt WritableStreamDefaultController.signal Document WritableStreamDefaultController.signal Mar 23, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a CI failure and I think it is because the name of the thing in the slug is wrong

@teoli2003
Copy link
Contributor Author

Oh yes! Silly me. Fixing.

teoli2003 and others added 8 commits March 23, 2023 11:41
…ex.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>
…ex.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>
…ex.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>
…ex.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo headline levels

teoli2003 and others added 2 commits March 23, 2023 11:48
…ex.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>
…ex.md

Co-authored-by: Florian Scholz <fs@florianscholz.com>
@Elchi3 Elchi3 merged commit 6a852f0 into mdn:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants