Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page: CSS filter functions guide #26096

Merged
merged 41 commits into from
Apr 14, 2023
Merged

New page: CSS filter functions guide #26096

merged 41 commits into from
Apr 14, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Apr 10, 2023 •
edited
Loading

Creates a new filter functions page.

Added the guide to the CSS filter effects module pages.

There was an error in grayscale, so fixed that.

@estelle estelle requested a review from a team as a code owner April 10, 2023 18:56
@estelle estelle requested review from dipikabh and removed request for a team April 10, 2023 18:56
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-04-14 13:43:19)

dipikabh
dipikabh requested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @estelle! Thanks for adding this content.
I've reviewed till "Applying multiple filters". I'll look at the remaining tomorrow.

files/en-us/web/css/filter-function/grayscale/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
@estelle @dipikabh
Apply suggestions from code review
885bd34 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle estelle requested a review from dipikabh April 13, 2023 01:23
dipikabh
dipikabh requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with reviewing the second half

files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter_effects/using_filter_effects/index.md Outdated Show resolved Hide resolved
teoli2003 and others added 3 commits April 13, 2023 09:19
@teoli2003
Fix the flaw
bb999fa
@estelle @teoli2003 @dipikabh
Apply suggestions from code review
25d202a 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
move hidden html
2be876b
@estelle estelle requested a review from dipikabh April 13, 2023 08:04
@dipikabh dipikabh merged commit 4275cc5 into mdn:main Apr 14, 2023
@dipikabh
Copy link
Contributor

Thanks @estelle 👍

@estelle estelle mentioned this pull request Apr 22, 2023
Open
@estelle estelle deleted the ufe branch August 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 left review comments

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @dipikabh @teoli2003